author | Jeff King <peff@peff.net> | |
Sun, 19 Dec 2010 03:36:41 +0000 (22:36 -0500) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Sun, 19 Dec 2010 18:46:08 +0000 (10:46 -0800) | ||
commit | db6195efab70aa3aca1cc8e39855f2cd58e0287b | |
tree | 5f1df1ed6ba928f8cc723db14c420b18e4722587 | tree | snapshot |
parent | b2be2f6aeaa8f4af602679e5571d2e916a259d91 | commit | diff |
handle arbitrary ints in git_config_maybe_bool
This function recently gained the ability to recognize the documented "0"
and "1" values as false/true. However, unlike regular git_config_bool, it
did not treat arbitrary non-zero numbers as true.
While this is undocumented and probably ridiculous for somebody to rely
on, it is safer to behave exactly as git_config_bool would. Because
git_config_maybe_bool can be used to retrofit new non-bool values onto
existing bool options, not behaving in exactly the same way is technically
a regression.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This function recently gained the ability to recognize the documented "0"
and "1" values as false/true. However, unlike regular git_config_bool, it
did not treat arbitrary non-zero numbers as true.
While this is undocumented and probably ridiculous for somebody to rely
on, it is safer to behave exactly as git_config_bool would. Because
git_config_maybe_bool can be used to retrofit new non-bool values onto
existing bool options, not behaving in exactly the same way is technically
a regression.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
config.c | diff | blob | history |