![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Johannes Sixt <j6t@kdbg.org> | |
| Tue, 30 Mar 2010 17:36:03 +0000 (19:36 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 30 Mar 2010 21:46:33 +0000 (14:46 -0700) | ||
| commit | da1fbed3fff6ed2d64399ff26d8a9ab3bcf00540 | |
| tree | b810119d3ab515951778b908c1c5ff2c5d47592a | tree | snapshot |
| parent | 657ab61efa918f46f1b412613643d1a1bbed2194 | commit | diff |
diff: fix textconv error zombies
To make the code simpler, run_textconv lumps all of its
error checking into one conditional. However, the
short-circuit means that an error in reading will prevent us
from calling finish_command, leaving a zombie child.
Clean up properly after errors.
Based-on-work-by: Jeff King <peff@peff.net>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
To make the code simpler, run_textconv lumps all of its
error checking into one conditional. However, the
short-circuit means that an error in reading will prevent us
from calling finish_command, leaving a zombie child.
Clean up properly after errors.
Based-on-work-by: Jeff King <peff@peff.net>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| diff.c | diff | blob | history |