author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
Wed, 21 Dec 2011 01:18:19 +0000 (01:18 +0000) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 21 Dec 2011 18:19:04 +0000 (10:19 -0800) | ||
commit | d7a10c3140de593abe25d55bbdba43373079e82e | |
tree | 3192f7d1cd63d0cf1df8c28831119c62fe7efbd5 | tree | snapshot |
parent | 3daff7c31998faedbe0dd7e2b8651e351be40d64 | commit | diff |
Fix an enum assignment issue spotted by Sun Studio
In builtin/fast-export.c we'd assign to variables of the
tag_of_filtered_mode enum type with constants defined for the
signed_tag_mode enum.
We'd get the intended value since both the value we were assigning
with and the one we actually wanted had the same positional within
their respective enums, but doing it this way makes no sense.
This issue was spotted by Sun Studio 12 Update 1:
"builtin/fast-export.c", line 54: warning: enum type mismatch: op "=" (E_ENUM_TYPE_MISMATCH_OP)
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In builtin/fast-export.c we'd assign to variables of the
tag_of_filtered_mode enum type with constants defined for the
signed_tag_mode enum.
We'd get the intended value since both the value we were assigning
with and the one we actually wanted had the same positional within
their respective enums, but doing it this way makes no sense.
This issue was spotted by Sun Studio 12 Update 1:
"builtin/fast-export.c", line 54: warning: enum type mismatch: op "=" (E_ENUM_TYPE_MISMATCH_OP)
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fast-export.c | diff | blob | history |