author | Paul Mackerras <paulus@samba.org> | |
Wed, 2 Jan 2008 10:44:06 +0000 (21:44 +1100) | ||
committer | Paul Mackerras <paulus@samba.org> | |
Wed, 2 Jan 2008 10:44:06 +0000 (21:44 +1100) | ||
commit | cd2bcae798ac2194f18374dc7dc10de404fd01d0 | |
tree | 09ffb73aca7cd90a1333b2e8da62e054cdd52e37 | tree | snapshot |
parent | 42a671fc006122159aec06da28045ffee49d3244 | commit | diff |
gitk: Fix a couple of bugs in the find function
First, findmore would sometimes get a Tcl error due to relying on
varcorder and vrownum having valid values for the rows being searched,
but they may not be valid unless update_arcrows is called, so this
makes findmore call update_arcrows if necessary.
Secondly, in the "touching paths" and "adding/removing string" modes,
findmore was treating fhighlights($row) == -1 as meaning the row
matches, whereas it only means that we haven't received an answer from
the external git diff-tree process about it yet. This fixes it.
Signed-off-by: Paul Mackerras <paulus@samba.org>
First, findmore would sometimes get a Tcl error due to relying on
varcorder and vrownum having valid values for the rows being searched,
but they may not be valid unless update_arcrows is called, so this
makes findmore call update_arcrows if necessary.
Secondly, in the "touching paths" and "adding/removing string" modes,
findmore was treating fhighlights($row) == -1 as meaning the row
matches, whereas it only means that we haven't received an answer from
the external git diff-tree process about it yet. This fixes it.
Signed-off-by: Paul Mackerras <paulus@samba.org>
gitk | diff | blob | history |