author | Junio C Hamano <gitster@pobox.com> | |
Fri, 27 Nov 2009 23:06:37 +0000 (15:06 -0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 27 Nov 2009 23:11:47 +0000 (15:11 -0800) | ||
commit | c970a6fd0142da3740f0205f16f91d3f2ed7e258 | |
tree | 8003818a9ccc50dbcb1f6a8f5b3dddca571a8d27 | tree | snapshot |
parent | 82d97da30aba767e5c8406b595274af299858357 | commit | diff |
Remove dead code from "git am"
Ever since the initial implementation, "git am" had kept a dead code that
never triggered due to a typo in the variable name. Worse yet, the code,
if it weren't for the typo, would have attempted to add "[PATCH] " at the
beginning of the Subject: header when "git am" is run with its "-k"
option. However, because "git am -k" tells mailinfo to keep such prefix
when parsing the input, the "[PATCH] " added by this dead code would have
really been unnecessary duplicate.
Embarrassing is that we kept _maintaining_ the codepath without anybody
noticing for four years.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ever since the initial implementation, "git am" had kept a dead code that
never triggered due to a typo in the variable name. Worse yet, the code,
if it weren't for the typo, would have attempted to add "[PATCH] " at the
beginning of the Subject: header when "git am" is run with its "-k"
option. However, because "git am -k" tells mailinfo to keep such prefix
when parsing the input, the "[PATCH] " added by this dead code would have
really been unnecessary duplicate.
Embarrassing is that we kept _maintaining_ the codepath without anybody
noticing for four years.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-am.sh | diff | blob | history |