author | Paul Mackerras <paulus@samba.org> | |
Sun, 6 Jan 2008 02:54:58 +0000 (13:54 +1100) | ||
committer | Paul Mackerras <paulus@samba.org> | |
Sun, 6 Jan 2008 02:54:58 +0000 (13:54 +1100) | ||
commit | c8c9f3d9cc9a21084c9fe4742d0e66b7c988635c | |
tree | 157b6a4af6637aec5ee9b9b6a97a1af511d87829 | tree | snapshot |
parent | cd2bcae798ac2194f18374dc7dc10de404fd01d0 | commit | diff |
gitk: Fix potential bug with fake commit IDs in renumbervarc
When a fake row is added, we add its (fake) ID to the children list
for its (fake) parent. If renumbervarc were to then renumber the
parent it would incorrectly use the fake child. This avoids the
problem by adding a last_real_child procedure which won't return
a fake ID, and using it in renumbervarc. For symmetry this also adds
a first_real_child procedure and uses it in ordertoken.
Signed-off-by: Paul Mackerras <paulus@samba.org>
When a fake row is added, we add its (fake) ID to the children list
for its (fake) parent. If renumbervarc were to then renumber the
parent it would incorrectly use the fake child. This avoids the
problem by adding a last_real_child procedure which won't return
a fake ID, and using it in renumbervarc. For symmetry this also adds
a first_real_child procedure and uses it in ordertoken.
Signed-off-by: Paul Mackerras <paulus@samba.org>
gitk | diff | blob | history |