Code

unquote_c_style: fix off-by-one.
authorPierre Habouzit <madcoder@debian.org>
Thu, 6 Mar 2008 21:28:19 +0000 (22:28 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 7 Mar 2008 21:31:30 +0000 (13:31 -0800)
commitc8744d6a8b27115503565041566d97c21e722584
treec070c6bef6f1bc5e1eb3fb4e6f952cfe097f6cdf
parentc2116a1783a3d555d41892ae7db0dd0934d4ddf1
unquote_c_style: fix off-by-one.

The optional endp parameter to unquote_c_style() was supposed to point at
a location past the closing double quote, but it was going one beyond it.

git-fast-import used this function heavily and the bug caused it to
misparse the input stream, especially when parsing a rename command:

R "filename that needs quoting" rename-target-name

Because the function erroneously ate the whitespace after the closing dq,
this triggered "Missing space after source" error when it shouldn't.

Thanks to Adeodato Simò for having caught this.

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
quote.c