![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Junio C Hamano <gitster@pobox.com> | |
| Wed, 5 Dec 2007 07:01:19 +0000 (23:01 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 6 Dec 2007 15:54:06 +0000 (07:54 -0800) | ||
| commit | c6bc40058565fef3ec79840bf5e13ba0962cb3e4 | |
| tree | abbd42d727f41f7e4ca5c3886e14be7f0049110e | tree | snapshot |
| parent | c9ecf4f12aecabfad87507ebd133476ea99fe4cb | commit | diff |
do not discard status in fetch_refs_via_pack()
The code calls fetch_pack() to get the list of refs it fetched, and
discards refs and always returns 0 to signal success.
But builtin-fetch-pack.c::fetch_pack() has error cases. The function
returns NULL if error is detected (shallow-support side seems to choose
to die but I suspect that is easily fixable to error out as well).
Make fetch_refs_via_pack() propagate that error to the caller.
Acked-By: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The code calls fetch_pack() to get the list of refs it fetched, and
discards refs and always returns 0 to signal success.
But builtin-fetch-pack.c::fetch_pack() has error cases. The function
returns NULL if error is detected (shallow-support side seems to choose
to die but I suspect that is easily fixable to error out as well).
Make fetch_refs_via_pack() propagate that error to the caller.
Acked-By: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| transport.c | diff | blob | history |