author | Junio C Hamano <gitster@pobox.com> | |
Mon, 9 May 2011 20:12:57 +0000 (13:12 -0700) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 9 May 2011 21:59:09 +0000 (14:59 -0700) | ||
commit | c61dcff9d6944eb35abf7fc7faa36f23a49fabf6 | |
tree | e8e20a235df8f60c5e86ae318a6f80cb45ac368a | tree | snapshot |
parent | ec70f52f6fb6d3e08c7b24f8b5bf25502d8ee59b | commit | diff |
convert: give saner names to crlf/eol variables, types and functions
Back when the conversion was only about the end-of-line convention, it
might have made sense to call what we do upon seeing CR/LF simply an
"action", but these days the conversion routines do a lot more than just
tweaking the line ending. Raname "action" to "crlf_action".
The function that decides what end of line conversion to use on the output
codepath was called "determine_output_conversion", as if there is no other
kind of output conversion. Rename it to "output_eol"; it is a function
that returns what EOL convention is to be used.
A function that decides what "crlf_action" needs to be used on the input
codepath, given what conversion attribute is set to the path and global
end-of-line convention, was called "determine_action". Rename it to
"input_crlf_action".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Back when the conversion was only about the end-of-line convention, it
might have made sense to call what we do upon seeing CR/LF simply an
"action", but these days the conversion routines do a lot more than just
tweaking the line ending. Raname "action" to "crlf_action".
The function that decides what end of line conversion to use on the output
codepath was called "determine_output_conversion", as if there is no other
kind of output conversion. Rename it to "output_eol"; it is a function
that returns what EOL convention is to be used.
A function that decides what "crlf_action" needs to be used on the input
codepath, given what conversion attribute is set to the path and global
end-of-line convention, was called "determine_action". Rename it to
"input_crlf_action".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
convert.c | diff | blob | history |