![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Dmitry Ivankov <divanorama@gmail.com> | |
| Mon, 20 Jun 2011 08:22:47 +0000 (14:22 +0600) | ||
| committer | Jonathan Nieder <jrnieder@gmail.com> | |
| Tue, 21 Jun 2011 10:02:57 +0000 (05:02 -0500) | ||
| commit | c5f1fbe7bc6b29f3343a168461ee70816ddebec2 | |
| tree | 378bbc256a49756576dd40c24343fede945215d6 | tree | snapshot |
| parent | 3ac10b2e3fd6d858621f796160d251ad34affc20 | commit | diff |
vcs-svn: do not initialize report_buffer twice
When importing from a dump with deltas, first fast_export_init calls
buffer_fdinit, and then init_report_buffer calls fdopen once again
when processing the first delta. The second initialization is
redundant and leaks a FILE *.
Remove the redundant on-demand initialization to fix this.
Initializing directly in fast_export_init is simpler and lets the
caller pass an int specifying which fd to use instead of hard-coding
REPORT_FILENO.
Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
When importing from a dump with deltas, first fast_export_init calls
buffer_fdinit, and then init_report_buffer calls fdopen once again
when processing the first delta. The second initialization is
redundant and leaks a FILE *.
Remove the redundant on-demand initialization to fix this.
Initializing directly in fast_export_init is simpler and lets the
caller pass an int specifying which fd to use instead of hard-coding
REPORT_FILENO.
Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
| vcs-svn/fast_export.c | diff | blob | history |