author | Andy Whitcroft <apw@shadowen.org> | |
Tue, 5 Sep 2006 19:00:17 +0000 (20:00 +0100) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Wed, 6 Sep 2006 00:40:46 +0000 (17:40 -0700) | ||
commit | c41e20b30b2bd4b8167917336676cde6f6aadd06 | |
tree | 14cfbfde32feb0491aeae8f23b301dfaee2dc890 | tree | snapshot |
parent | 825b045f52daa2c8f28370f30c759adbdec51cbb | commit | diff |
send-pack: remove remote reference limit
When build a pack for a push we query the remote copy for existant
heads. These are used to prune unnecessary objects from the pack.
As we receive the remote references in get_remote_heads() we validate
the reference names via check_ref() which includes a length check;
rejecting those >45 characters in size.
This is a miss converted change, it was originally designed to reject
messages which were less than 45 characters in length (a 40 character
sha1 and refs/) to prevent comparing unitialised memory. check_ref()
now gets the raw length so check for at least 5 characters.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
When build a pack for a push we query the remote copy for existant
heads. These are used to prune unnecessary objects from the pack.
As we receive the remote references in get_remote_heads() we validate
the reference names via check_ref() which includes a length check;
rejecting those >45 characters in size.
This is a miss converted change, it was originally designed to reject
messages which were less than 45 characters in length (a 40 character
sha1 and refs/) to prevent comparing unitialised memory. check_ref()
now gets the raw length so check for at least 5 characters.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
connect.c | diff | blob | history |