Code

Fix sparse warnings
authorStephen Boyd <bebarino@gmail.com>
Tue, 22 Mar 2011 07:51:05 +0000 (00:51 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 22 Mar 2011 17:16:54 +0000 (10:16 -0700)
commitc2e86addb86689306b992065328ec52aa2479658
tree4d1ddf84e727b2046b46fd02f588b96876384c5c
parent08c8d5581363998fda2803da2620d47fe8b50f0d
Fix sparse warnings

Fix warnings from 'make check'.

 - These files don't include 'builtin.h' causing sparse to complain that
   cmd_* isn't declared:

   builtin/clone.c:364, builtin/fetch-pack.c:797,
   builtin/fmt-merge-msg.c:34, builtin/hash-object.c:78,
   builtin/merge-index.c:69, builtin/merge-recursive.c:22
   builtin/merge-tree.c:341, builtin/mktag.c:156, builtin/notes.c:426
   builtin/notes.c:822, builtin/pack-redundant.c:596,
   builtin/pack-refs.c:10, builtin/patch-id.c:60, builtin/patch-id.c:149,
   builtin/remote.c:1512, builtin/remote-ext.c:240,
   builtin/remote-fd.c:53, builtin/reset.c:236, builtin/send-pack.c:384,
   builtin/unpack-file.c:25, builtin/var.c:75

 - These files have symbols which should be marked static since they're
   only file scope:

   submodule.c:12, diff.c:631, replace_object.c:92, submodule.c:13,
   submodule.c:14, trace.c:78, transport.c:195, transport-helper.c:79,
   unpack-trees.c:19, url.c:3, url.c:18, url.c:104, url.c:117, url.c:123,
   url.c:129, url.c:136, thread-utils.c:21, thread-utils.c:48

 - These files redeclare symbols to be different types:

   builtin/index-pack.c:210, parse-options.c:564, parse-options.c:571,
   usage.c:49, usage.c:58, usage.c:63, usage.c:72

 - These files use a literal integer 0 when they really should use a NULL
   pointer:

   daemon.c:663, fast-import.c:2942, imap-send.c:1072, notes-merge.c:362

While we're in the area, clean up some unused #includes in builtin files
(mostly exec_cmd.h).

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
35 files changed:
builtin/clone.c
builtin/fetch-pack.c
builtin/fmt-merge-msg.c
builtin/hash-object.c
builtin/index-pack.c
builtin/merge-index.c
builtin/merge-recursive.c
builtin/merge-tree.c
builtin/mktag.c
builtin/notes.c
builtin/pack-redundant.c
builtin/pack-refs.c
builtin/patch-id.c
builtin/remote-ext.c
builtin/remote-fd.c
builtin/remote.c
builtin/reset.c
builtin/send-pack.c
builtin/unpack-file.c
builtin/var.c
daemon.c
diff.c
fast-import.c
imap-send.c
notes-merge.c
parse-options.c
replace_object.c
submodule.c
thread-utils.c
trace.c
transport-helper.c
transport.c
unpack-trees.c
url.c
usage.c