author | Linus Torvalds <torvalds@linux-foundation.org> | |
Tue, 11 Dec 2007 04:08:06 +0000 (20:08 -0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Tue, 11 Dec 2007 08:38:46 +0000 (00:38 -0800) | ||
commit | be15f50538afa4bfb912a86fa9d9f141010ad691 | |
tree | a5d45d355b235ba24f0d50bebea6867841ebc446 | tree | snapshot |
parent | ace9c2a9dd7c9e54194998fc6b7c677dbb7d0902 | commit | diff |
"git tag -u keyname" broken
Commit 396865859918e9c7bf8ce74aae137c57da134610 broke signed tags using
the "-u" flag when it made builtin-tag.c use parse_options() to parse its
arguments (but it quite possibly was broken even before that, by the
builtin rewrite).
It used to be that passing the signing ID with the -u parameter also
(obviously!) implied that you wanted to sign and annotate the tag, but
that logic got dropped. It also totally ignored the actual key ID that was
passed in.
This reinstates it all.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commit 396865859918e9c7bf8ce74aae137c57da134610 broke signed tags using
the "-u" flag when it made builtin-tag.c use parse_options() to parse its
arguments (but it quite possibly was broken even before that, by the
builtin rewrite).
It used to be that passing the signing ID with the -u parameter also
(obviously!) implied that you wanted to sign and annotate the tag, but
that logic got dropped. It also totally ignored the actual key ID that was
passed in.
This reinstates it all.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-tag.c | diff | blob | history | |
t/t7004-tag.sh | diff | blob | history |