![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Linus Torvalds <torvalds@osdl.org> | |
| Wed, 27 Jul 2005 03:04:22 +0000 (20:04 -0700) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Wed, 27 Jul 2005 05:23:18 +0000 (22:23 -0700) | ||
| commit | bdf25142aaac016f4d992001f336d53ab4fbc75e | |
| tree | 41d575f73b853d02144086a55f643fe037a49b97 | tree | snapshot |
| parent | 2779fad61302da0fe3a24995e343ab894f32fa42 | commit | diff |
Fix potential send-pack SIGSEGV
The check that the source is ahead of the destination incorrectly expects
pop_most_recent_commit() to gracefully handle an empty list.
Fix by just checking the list itself, rather than the return value of the
pop function.
[jc: I did the test script that demonstrated the problem]
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
The check that the source is ahead of the destination incorrectly expects
pop_most_recent_commit() to gracefully handle an empty list.
Fix by just checking the list itself, rather than the return value of the
pop function.
[jc: I did the test script that demonstrated the problem]
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| send-pack.c | diff | blob | history | |
| t/t5400-send-pack.sh | [new file with mode: 0755] | blob |