author | Libor Pechacek <lpechacek@suse.cz> | |
Sun, 30 Jan 2011 19:40:41 +0000 (20:40 +0100) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Tue, 22 Feb 2011 23:19:45 +0000 (15:19 -0800) | ||
commit | b09c53a3e331211fc0154de8ebb271e48f8c7ee5 | |
tree | 341eeb6f6252abd6bf0d5415efe2afcffc3d4c52 | tree | snapshot |
parent | 597a63054241c122515c93cbce45bc44eb231f18 | commit | diff |
Sanity-check config variable names
Sanity-check config variable names when adding and retrieving them. As a side
effect code duplication between git_config_set_multivar and get_value (in
builtin/config.c) was removed and the common functionality was placed in
git_config_parse_key.
This breaks a test in t1300 which used invalid section-less keys in the tests
for "git -c". However, allowing such names there was useless, since there was
no way to set them via config file, and no part of git actually tried to use
section-less keys. This patch updates the test to use more realistic examples
as well as adding its own test.
Signed-off-by: Libor Pechacek <lpechacek@suse.cz>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Sanity-check config variable names when adding and retrieving them. As a side
effect code duplication between git_config_set_multivar and get_value (in
builtin/config.c) was removed and the common functionality was placed in
git_config_parse_key.
This breaks a test in t1300 which used invalid section-less keys in the tests
for "git -c". However, allowing such names there was useless, since there was
no way to set them via config file, and no part of git actually tried to use
section-less keys. This patch updates the test to use more realistic examples
as well as adding its own test.
Signed-off-by: Libor Pechacek <lpechacek@suse.cz>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/config.c | diff | blob | history | |
cache.h | diff | blob | history | |
config.c | diff | blob | history | |
t/t1300-repo-config.sh | diff | blob | history |