Code

log-tree: fix patch filename computation in "git format-patch"
authorChristian Couder <chriscool@tuxfamily.org>
Fri, 27 Mar 2009 00:13:01 +0000 (01:13 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 27 Mar 2009 08:10:27 +0000 (01:10 -0700)
commitb09b868f7fee689483d00bea3d52c0f14a80386c
treec2d78825b88e34ce66b4b48e3642151297233dd3
parent747e25050bfef8f3a7c882954b654cf6d97fc63e
log-tree: fix patch filename computation in "git format-patch"

When using "git format-patch", "get_patch_filename" in
"log-tree.c" calls "strbuf_splice" that could die with
the following message:

"`pos + len' is too far after the end of the buffer"

if you have:

buf->len < start_len + FORMAT_PATCH_NAME_MAX

but:

buf->len + suffix_len > start_len + FORMAT_PATCH_NAME_MAX

This patch tries to get rid of that bug.

[jc: w/ simplified logic]

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
log-tree.c