author | Marc Fournier <marc.fournier@camptocamp.com> | |
Wed, 25 Mar 2015 23:01:54 +0000 (00:01 +0100) | ||
committer | Marc Fournier <marc.fournier@camptocamp.com> | |
Wed, 25 Mar 2015 23:55:21 +0000 (00:55 +0100) | ||
commit | aa434cf4f73aec28334943ce04f8e5e2e370f9c3 | |
tree | f54aa906bc9c1c206480a07ce47fb2f0cf1b7fa8 | tree | snapshot |
parent | 5b1d67d04e490d48dd72dbb9f84d1a74bfb9dcc1 | commit | diff |
write_http: adapt the behaviour of Timeout option
- rename PostTimeoutSec parameter to Timeout
- change Timeout to take milliseconds rather than seconds, for the sake
of consistency: collectd allow working at the sub-second scale if need
be, so it's a shame to restrain this here.
- do *not* set the default timeout to the value of Interval. Rationale:
what matters here is that each POST request completes before the send
buffer fills up again. How fast the send buffer fills up completely
depends on how much data is collected. Interval is unrelated to this,
and unlike read plugins, I don't think it makes a good value to use as
the default timeout.
- rename PostTimeoutSec parameter to Timeout
- change Timeout to take milliseconds rather than seconds, for the sake
of consistency: collectd allow working at the sub-second scale if need
be, so it's a shame to restrain this here.
- do *not* set the default timeout to the value of Interval. Rationale:
what matters here is that each POST request completes before the send
buffer fills up again. How fast the send buffer fills up completely
depends on how much data is collected. Interval is unrelated to this,
and unlike read plugins, I don't think it makes a good value to use as
the default timeout.
src/collectd.conf.pod | diff | blob | history | |
src/write_http.c | diff | blob | history |