Code

clone: die when trying to clone missing local path
authorJeff King <peff@peff.net>
Fri, 18 Feb 2011 04:01:52 +0000 (23:01 -0500)
committerJunio C Hamano <gitster@pobox.com>
Fri, 18 Feb 2011 15:05:54 +0000 (07:05 -0800)
commita9026187923643235d4f9b876ff5f4c0ebe5c9ae
tree6a61ec682b5ce41edec0f9188c5319263b8cd410
parent7ed863a85a6ce2c4ac4476848310b8f917ab41f9
clone: die when trying to clone missing local path

Since 86ac751 (Allow cloning an empty repository,
2009-01-23), doing:

  git clone does-not-exist

has created does-not-exist as an empty repository. This was
an unintentional side effect of 86ac751. Even weirder,
doing:

  git clone does-not-exist new-dir

_does_ fail, making this "feature" (if you want to consider
it such) broken. Let's detect this situation and explicitly
die. It's almost certainly not what the user intended.

This patch also adds two tests. One for the missing path
case, and one to confirm that a similar case, cloning a
non-repository directory, fails.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/clone.c
t/t5701-clone-local.sh