![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Jonas Fonseca <fonseca@diku.dk> | |
| Tue, 29 May 2007 11:08:21 +0000 (13:08 +0200) | ||
| committer | Jonas Fonseca <fonseca@diku.dk> | |
| Tue, 29 May 2007 11:08:21 +0000 (13:08 +0200) | ||
| commit | a39653656755cc0d01165043922d6f38b2db2cf9 | |
| tree | 4daa0a5aab1a41d3285ad95cf151bc937f440221 | tree | snapshot |
| parent | 0a0d891082ac72087026071ab30a39381da75da3 | commit | diff |
move_view: fix view->offset overflow bug
Reproducable by opening the tree view, then maximizing the blob view,
move up, and then closing the blob view, causing the view->offset to
have "wrapped around" and nothing to be displayed in the tree view.
The invalid update of view->offset only happend when moving
non-displayed views. Instead use the checked scroll_steps variable
instead of the steps variable. Add a guarding assert after the update.
Reproducable by opening the tree view, then maximizing the blob view,
move up, and then closing the blob view, causing the view->offset to
have "wrapped around" and nothing to be displayed in the tree view.
The invalid update of view->offset only happend when moving
non-displayed views. Instead use the checked scroll_steps variable
instead of the steps variable. Add a guarding assert after the update.
| tig.c | diff | blob | history |