Code

parse-options: Don't call parse_options_check() so much
authorStephen Boyd <bebarino@gmail.com>
Mon, 6 Dec 2010 07:57:42 +0000 (23:57 -0800)
committerJunio C Hamano <gitster@pobox.com>
Tue, 7 Dec 2010 00:51:36 +0000 (16:51 -0800)
commit9ca1169fd92c71ebbef92ff18aa5d91a2157d1bd
treea1490182bae47da917a1d64a3ce1a52dbece0425
parent16529f2e5630d3d155e4dff0ebd3c7c5daa882f9
parse-options: Don't call parse_options_check() so much

parse_options_check() is being called for each invocation of
parse_options_step which can be quite a bit for some commands. The
commit introducing this function cb9d398 (parse-options: add
parse_options_check to validate option specs., 2009-06-09) had the
correct motivation and explicitly states that parse_options_check()
should be called from parse_options_start(). However, the implementation
differs from the motivation. Fix it.

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/blame.c
builtin/shortlog.c
parse-options.c
parse-options.h