![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> | |
| Tue, 5 Apr 2011 02:14:16 +0000 (22:14 -0400) | ||
| committer | Paul Mackerras <paulus@samba.org> | |
| Sun, 24 Jul 2011 05:34:54 +0000 (15:34 +1000) | ||
| commit | 929f577e0a648dd1c90b92d8a3f6f1899f2fa0e2 | |
| tree | 2c65d24a2fa573b6883ab84c4ea79bfa25bde875 | tree | snapshot |
| parent | 784b7e2f25ce2a812d6b2dcbe4d3a2ea93484bb4 | commit | diff |
gitk: Put temporary directory inside .git
When running "External diff" from gitk, the "from" and "to" files will
first be copied into a directory that is currently
".git/../.gitk-tmp.$pid". When gitk is closed, the directory is
deleted. When the work tree is not at ".git/.." (which is supported
since the previous commit), that directory may not even be git-related
and it does not seem unlikely that permissions may not allow the
temporary directory to be created there. Move the directory inside
.git instead.
This introduces a regression in the case that the .git directory
is readonly, but .git/.. is writeable.
Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
When running "External diff" from gitk, the "from" and "to" files will
first be copied into a directory that is currently
".git/../.gitk-tmp.$pid". When gitk is closed, the directory is
deleted. When the work tree is not at ".git/.." (which is supported
since the previous commit), that directory may not even be git-related
and it does not seem unlikely that permissions may not allow the
temporary directory to be created there. Move the directory inside
.git instead.
This introduces a regression in the case that the .git directory
is readonly, but .git/.. is writeable.
Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
| gitk | diff | blob | history |