Code

Rename resolve_ref() to resolve_ref_unsafe()
authorNguyễn Thái Ngọc Duy <pclouds@gmail.com>
Mon, 12 Dec 2011 11:20:32 +0000 (18:20 +0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 13 Dec 2011 17:39:46 +0000 (09:39 -0800)
commit8cad4744ee37ebec1d9491a1381ec1771a1ba795
tree064bbe938f38727dd163aae9c95e2185b8075234
parent96ec7b1e708863d0cd6b8e72a986d6f0a1bb64db
Rename resolve_ref() to resolve_ref_unsafe()

resolve_ref() may return a pointer to a shared buffer and can be
overwritten by the next resolve_ref() calls. Callers need to
pay attention, not to keep the pointer when the next call happens.

Rename with "_unsafe" suffix to warn developers (or reviewers) before
introducing new call sites.

This patch is generated using the following command

git grep -l 'resolve_ref(' -- '*.[ch]'|xargs sed -i 's/resolve_ref(/resolve_ref_unsafe(/g'

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
13 files changed:
branch.c
builtin/branch.c
builtin/commit.c
builtin/fsck.c
builtin/log.c
builtin/receive-pack.c
builtin/remote.c
builtin/show-branch.c
builtin/symbolic-ref.c
cache.h
refs.c
remote.c
transport.c