Code

diff: don't run pager if user asked for a diff style exit code
authorRené Scharfe <rene.scharfe@lsrfire.ath.cx>
Sun, 12 Aug 2007 17:46:55 +0000 (19:46 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 13 Aug 2007 20:06:23 +0000 (13:06 -0700)
commit89d07f750a3f878c42b3de96ee93dc571b42b230
tree9f841785ead20a6a67e0e15353b2449aa6b65f00
parent4b37666ccbab015e75fda745c29a2f5d58a54482
diff: don't run pager if user asked for a diff style exit code

As Wincent Colaiuta found out, it's a bit unexpected for git diff to
start a pager even when the --quiet option is specified.  The problem
is that the pager hides the return code -- which is the only output
we're interested in in this case.

Push pager setup down into builtin-diff.c and don't start the pager
if --exit-code or --quiet (which implies --exit-code) was specified.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-diff.c
git.c