Code

diff: do not use configuration magic at the core-level
authorJunio C Hamano <junkio@cox.net>
Sat, 8 Jul 2006 08:05:16 +0000 (01:05 -0700)
committerJunio C Hamano <junkio@cox.net>
Sat, 8 Jul 2006 10:11:01 +0000 (03:11 -0700)
commit83ad63cfebdf652ff7c7b255d700d8b12c756913
treed23227484e77cc05bd534675554279f174cf7642
parentb53766483ff14f73be954617349b18ea56c3187a
diff: do not use configuration magic at the core-level

The Porcelainish has become so much usable as the UI that there
is not much reason people should be using the core programs by
hand anymore.  At this point we are better off making the
behaviour of the core programs predictable by keeping them
unaffected by the configuration variables.  Otherwise they will
become very hard to use as reliable building blocks.

For example, "git-commit -a" internally uses git-diff-files to
figure out the set of paths that need to be updated in the
index, and we should never allow diff.renames that happens to be
in the configuration to interfere (or slow down the process).

The UI level configuration such as showing renamed diff and
coloring are still honored by the Porcelainish ("git log" family
and "git diff"), but not by the core anymore.

Signed-off-by: Junio C Hamano <junkio@cox.net>
builtin-diff-files.c
builtin-diff-index.c
builtin-diff-stages.c
builtin-diff-tree.c
builtin-diff.c
builtin-log.c
diff.c
diff.h