author | Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk> | |
Sun, 30 Jul 2006 21:42:25 +0000 (22:42 +0100) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Wed, 2 Aug 2006 07:27:18 +0000 (00:27 -0700) | ||
commit | 822a7d507151e1d6310f52d5b05234d65db11a88 | |
tree | 649ce1c6b078ed5a040f5ffb91cf847c023a473f | tree | snapshot |
parent | 8e76483ce0ce256b01345abc4ca97b1f94aed354 | commit | diff |
Remove cmd_usage() routine and re-organize the help/usage code.
The cmd_usage() routine was causing warning messages due to a NULL
format parameter being passed in three out of four calls. This is a
problem if you want to compile with -Werror. A simple solution is to
simply remove the GNU __attribute__ format pragma from the cmd_usage()
declaration in the header file. The function interface was somewhat
muddled anyway, so re-write the code to finesse the problem.
[jc: this incidentally revealed that t9100 test assumed that the output
from "git help" to be fixed in stone, but this patch lower-cases
"Usage" to "usage". Update the test not to rely on "git help" output.]
Signed-off-by: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
The cmd_usage() routine was causing warning messages due to a NULL
format parameter being passed in three out of four calls. This is a
problem if you want to compile with -Werror. A simple solution is to
simply remove the GNU __attribute__ format pragma from the cmd_usage()
declaration in the header file. The function interface was somewhat
muddled anyway, so re-write the code to finesse the problem.
[jc: this incidentally revealed that t9100 test assumed that the output
from "git help" to be fixed in stone, but this patch lower-cases
"Usage" to "usage". Update the test not to rely on "git help" output.]
Signed-off-by: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <junkio@cox.net>
builtin-help.c | diff | blob | history | |
builtin.h | diff | blob | history | |
git.c | diff | blob | history | |
t/t9100-git-svn-basic.sh | diff | blob | history |