author | Jonathan Nieder <jrnieder@gmail.com> | |
Fri, 23 Jul 2010 17:03:07 +0000 (12:03 -0500) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 23 Jul 2010 21:42:36 +0000 (14:42 -0700) | ||
commit | 800f11040dec4efc4d94206869d9004b23dd700a | |
tree | ea9cce556f27a45b8be7006bdd83fec13538c85a | tree | snapshot |
parent | 64fdc08dac6694d1e754580e7acb82dfa4988bb9 | commit | diff |
t4150 (am): style fix
Place setup commands in test_expect_success blocks. This makes the
rare event of the setup commands breaking on some platform easier to
diagnose, and more importantly, it visually distinguishes where
each test begins and ends.
Instead of running test -z against the result of "git diff" command
substitution, use "git diff --exit-code", to improve output when
running with the "-v" option.
Use test_cmp in place of "test $(foo) = $(bar)" for similar reasons.
Remove whitespace after the > and < redirection operators for
consistency with other tests.
The order of arguments to test_cmp is "test_cmp expected actual".
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Place setup commands in test_expect_success blocks. This makes the
rare event of the setup commands breaking on some platform easier to
diagnose, and more importantly, it visually distinguishes where
each test begins and ends.
Instead of running test -z against the result of "git diff" command
substitution, use "git diff --exit-code", to improve output when
running with the "-v" option.
Use test_cmp in place of "test $(foo) = $(bar)" for similar reasons.
Remove whitespace after the > and < redirection operators for
consistency with other tests.
The order of arguments to test_cmp is "test_cmp expected actual".
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t4150-am.sh | diff | blob | history | |
t/test-lib.sh | diff | blob | history |