Code

fast-import pull request
authorJunio C Hamano <gitster@pobox.com>
Sun, 19 Aug 2007 09:50:18 +0000 (02:50 -0700)
committerShawn O. Pearce <spearce@spearce.org>
Sun, 19 Aug 2007 17:11:01 +0000 (13:11 -0400)
commit7e5dcea8311472156ed0fea164e689777353f931
tree3310c05585f207c77bb377e9d190a826cbba9809
parent904b1941514e78543bd636b4db71fbcf57898388
fast-import pull request

* skip_optional_lf() decl is old-style -- please say

static skip_optional_lf(void)
        {
         ...
}

* t9300 #14 fails, like this:

* expecting failure: git-fast-import <input
fatal: Branch name doesn't conform to GIT standards: .badbranchname
fast-import: dumping crash report to .git/fast_import_crash_14354
./test-lib.sh: line 143: 14354 Segmentation fault      git-fast-import <input

-- >8 --
Subject: [PATCH] fastimport: Fix re-use of va_list

The va_list is designed to be used only once. The current code
reuses va_list argument may cause segmentation fault.  Copy and
release the arguments to avoid this problem.

While we are at it, fix old-style function declaration of
skip_optional_lf().

Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
fast-import.c