Code

gitweb: Fix bug in href(..., -replay=>1) when using 'pathinfo' form
authorJakub Narebski <jnareb@gmail.com>
Thu, 14 Feb 2008 08:22:30 +0000 (09:22 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 12 Mar 2008 16:43:08 +0000 (09:43 -0700)
commit7863c612f402268b5978683f44adad3a7a867613
tree401ced768f29e3d290af4f2d10e68fe13417f601
parentea14e6c55427f50f78fe47187cd4edb9845943a1
gitweb: Fix bug in href(..., -replay=>1) when using 'pathinfo' form

URLs generated by href(..., -replay=>1) (which includes 'next page'
links and alternate view links) didn't set project info correctly
when current page URL is in pathinfo form.

This resulted in broken links such like:

  http://www.example.com/w/ARRAY(0x85a5318)?a=shortlog;pg=1

if the 'pathinfo' feature was used, or

  http://www.example.com/w/?a=shortlog;pg=1

if it wasn't, instead of correct:

  http://www.example.com/w/project.git?a=shortlog;pg=1

This was caused by the fact that href() always replays params in the
arrayref form, were they multivalued or singlevalued, and the code
dealing with 'pathinfo' feature couldn't deal with $params{'project'}
being arrayref.

Setting $params{'project'} is moved before replaying params; this
ensures that 'project' parameter is processed correctly.

Noticed-by: Peter Oberndorfer <kumbayo84@arcor.de>
Noticed-by: Wincent Colaiuta <win@wincent.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl