author | Pierre-Yves Ritschard <pyr@spootnik.org> | |
Wed, 19 Nov 2014 15:00:54 +0000 (16:00 +0100) | ||
committer | Pierre-Yves Ritschard <pyr@spootnik.org> | |
Wed, 19 Nov 2014 15:07:25 +0000 (16:07 +0100) | ||
commit | 781f635e0a1bb1f85b4e415f21eea68181c3f8dd | |
tree | 8f3514708fc8ba51485e8c161911573f6f66a431 | tree | snapshot |
parent | 2267812b24a0edd2519e66b80a756b1ae529777e | commit | diff |
Let snmp_synch_response deal with PDU freeing
When reading from tables, upon errors the PDUs sent are already
freed by snmp_synch_response since they are right after
snmp_send is called.
This commit syncs collectd's approach with other occurences of
snmp_synch_response calls.
There might be a few corner cases where we leak PDUs, but it
is unclear how to check for those since we would need to
have an indication that snmp_send was never called, which
as far as I can tell is not possible.
The potential for failure in snmp_send is rather low and will
be easily spotted though, since when crafting invalid PDUs
snmp send will constantly fail and since valid configurations
can never leak memory.
This fixes #804
When reading from tables, upon errors the PDUs sent are already
freed by snmp_synch_response since they are right after
snmp_send is called.
This commit syncs collectd's approach with other occurences of
snmp_synch_response calls.
There might be a few corner cases where we leak PDUs, but it
is unclear how to check for those since we would need to
have an indication that snmp_send was never called, which
as far as I can tell is not possible.
The potential for failure in snmp_send is rather low and will
be easily spotted though, since when crafting invalid PDUs
snmp send will constantly fail and since valid configurations
can never leak memory.
This fixes #804
src/snmp.c | diff | blob | history |