author | Linus Torvalds <torvalds@osdl.org> | |
Tue, 30 Aug 2005 18:04:39 +0000 (11:04 -0700) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Tue, 30 Aug 2005 18:57:28 +0000 (11:57 -0700) | ||
commit | 670f5fe34f0f6a363297d5dcd73051089b78fe82 | |
tree | 615d6a98d870d8822ce6cb5e2b61a18cf50ecb2e | tree | snapshot |
parent | 61f01a5b773915402da37a34e706db56fe90b776 | commit | diff |
[PATCH] Fix bisection terminating condition
When testing bisection and using gitk to visualize the result, it was
obvious that the termination condition was broken.
We know what the bad entry is only when the bisection ends up telling us
to test the known-bad entry again.
Also, add a safety net: if somebody marks as good something that includes
the known-bad point, we now notice and complain, instead of writing an
empty revision to the new bisection branch.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
When testing bisection and using gitk to visualize the result, it was
obvious that the termination condition was broken.
We know what the bad entry is only when the bisection ends up telling us
to test the known-bad entry again.
Also, add a safety net: if somebody marks as good something that includes
the known-bad point, we now notice and complain, instead of writing an
empty revision to the new bisection branch.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
git-bisect-script | diff | blob | history |