Code

string_list_append: always set util pointer to NULL
authorJeff King <peff@peff.net>
Sat, 12 Feb 2011 05:18:51 +0000 (00:18 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 14 Feb 2011 18:55:03 +0000 (10:55 -0800)
commit62b8102c60a716e66cfd2a33e596e9d5be134267
treed3def01dc545c9ba7d4bf6962f0c8ca139928572
parentdab0d4108d7b45905a12ec6cea2cfc20ea8eabef
string_list_append: always set util pointer to NULL

It is not immediately obvious that the util field may
contain random bytes after appending an item. Especially
since the string_list_insert* functions _do_ explicitly zero
the util pointer.

This does not appear to be a bug in any current git code, as
all callers either fill in the util field immediately or
never use it. However, it is worth it to be less surprising
to new users of the string-list API who may expect it to be
intialized to NULL.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
string-list.c