Code

drop length argument of has_extension
authorRene Scharfe <rene.scharfe@lsrfire.ath.cx>
Fri, 11 Aug 2006 12:01:45 +0000 (14:01 +0200)
committerJunio C Hamano <junkio@cox.net>
Fri, 11 Aug 2006 23:06:34 +0000 (16:06 -0700)
commit5bb1cda5f73988963e7470f3cd75a380751f6d99
tree550b8a6f962d816b7fa0e796d1c5d1f4037d0375
parentca9e3b124f6313187da641b5cd55100c4ade6a9a
drop length argument of has_extension

As Fredrik points out the current interface of has_extension() is
potentially confusing.  Its parameters include both a nul-terminated
string and a length-limited string.

This patch drops the length argument, requiring two nul-terminated
strings; all callsites are updated.  I checked that all of them indeed
provide nul-terminated strings.  Filenames need to be nul-terminated
anyway if they are to be passed to open() etc.  The performance penalty
of the additional strlen() is negligible compared to the system calls
which inevitably surround has_extension() calls.

Additionally, change has_extension() to use size_t inside instead of
int, as that is the exact type strlen() returns and memcmp() expects.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <junkio@cox.net>
builtin-help.c
git-compat-util.h
http-fetch.c
index-pack.c
local-fetch.c
refs.c
sha1_file.c
verify-pack.c