author | Michael J Gruber <git@drmicha.warpmail.net> | |
Tue, 17 May 2011 15:38:53 +0000 (17:38 +0200) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 18 May 2011 04:01:29 +0000 (21:01 -0700) | ||
commit | 5a2df368c26e4a993db9d09f221af1063d0fe9a8 | |
tree | 6cc663c9a4a1d8582a30f643915df09f7f8463c0 | tree | snapshot |
parent | 7a39741999a5216257b1fbcc847cf0c62c114088 | commit | diff |
config: Give error message when not changing a multivar
When trying to set a multivar with "git config var value", "git config"
issues
warning: remote.repoor.push has multiple values
leaving the user under the impression that the operation succeeded,
unless one checks the return value.
Instead, make it
warning: remote.repoor.push has multiple values
error: cannot overwrite multiple values with a single value
Use a regexp, --add or --set-all to change remote.repoor.push.
to be clear and helpful.
Note: The "warning" is raised through other code paths also so that it
needs to remain a warning for these (which do not raise the error). Only
the caller can determine how to go on from that.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When trying to set a multivar with "git config var value", "git config"
issues
warning: remote.repoor.push has multiple values
leaving the user under the impression that the operation succeeded,
unless one checks the return value.
Instead, make it
warning: remote.repoor.push has multiple values
error: cannot overwrite multiple values with a single value
Use a regexp, --add or --set-all to change remote.repoor.push.
to be clear and helpful.
Note: The "warning" is raised through other code paths also so that it
needs to remain a warning for these (which do not raise the error). Only
the caller can determine how to go on from that.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/config.c | diff | blob | history |