author | Clemens Buchacher <drizzd@aon.at> | |
Sat, 7 Jan 2012 11:42:47 +0000 (12:42 +0100) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Sun, 8 Jan 2012 23:08:11 +0000 (15:08 -0800) | ||
commit | 561b133c2c29ccf5e2aeaa5d6b1da3835e660db8 | |
tree | d04a1d4d26ccb77ab0ad44c7fc64d7aa3f0184e4 | tree | snapshot |
parent | f6a34cfbb4314105c4dadd88eb42da26aef44dfd | commit | diff |
git-daemon tests: wait until daemon is ready
In start_daemon, git-daemon is started as a background process. In
theory, the tests may try to connect before the daemon had a chance
to open a listening socket. Avoid this race condition by waiting
for it to output "Ready to rumble". Any other output is considered
an error and the test is aborted.
Should git-daemon produce no output at all, lib-git-daemon would
block forever. This could be fixed by introducing a timeout. On
the other hand, we have no timeout for other git commands which
could suffer from the same problem. Since such a mechanism adds
some complexity, I have decided against it.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In start_daemon, git-daemon is started as a background process. In
theory, the tests may try to connect before the daemon had a chance
to open a listening socket. Avoid this race condition by waiting
for it to output "Ready to rumble". Any other output is considered
an error and the test is aborted.
Should git-daemon produce no output at all, lib-git-daemon would
block forever. This could be fixed by introducing a timeout. On
the other hand, we have no timeout for other git commands which
could suffer from the same problem. Since such a mechanism adds
some complexity, I have decided against it.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/lib-git-daemon.sh | diff | blob | history |