author | Tay Ray Chuan <rctay89@gmail.com> | |
Thu, 3 Dec 2009 23:31:44 +0000 (07:31 +0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 4 Dec 2009 00:00:20 +0000 (16:00 -0800) | ||
commit | 53970b92d9dc883669f3a9b79b5e39e73931b331 | |
tree | 329353c73dd255a5022fb48a9b27156b4d240b11 | tree | snapshot |
parent | 2fe40b63001844f9a884ac9cb49cabd5e183b62f | commit | diff |
builtin-push: don't access freed transport->url
Move the failed push message to before transport_disconnect() so that
it doesn't access transport->url after transport has been free()'d (in
transport_disconnect()).
Additionally, make the failed push message more accurate by moving it
before transport_disconnect(), so that it doesn't report errors due
to a failed disconnect.
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Acked-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Move the failed push message to before transport_disconnect() so that
it doesn't access transport->url after transport has been free()'d (in
transport_disconnect()).
Additionally, make the failed push message more accurate by moving it
before transport_disconnect(), so that it doesn't report errors due
to a failed disconnect.
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Acked-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-push.c | diff | blob | history |