author | Gary V. Vaughan <git@mlists.thewrittenword.com> | |
Fri, 14 May 2010 09:31:35 +0000 (09:31 +0000) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 31 May 2010 23:59:27 +0000 (16:59 -0700) | ||
commit | 4b05548fc0523744b7a1276cfa0f4aae19d6d9c9 | |
tree | baf4bc01f49247b8811ed5d87dede2456e8b5eff | tree | snapshot |
parent | 48793cf46a286a21df420fdd7fc4b0c91c60a0c8 | commit | diff |
enums: omit trailing comma for portability
Without this patch at least IBM VisualAge C 5.0 (I have 5.0.2) on AIX
5.1 fails to compile git.
enum style is inconsistent already, with some enums declared on one
line, some over 3 lines with the enum values all on the middle line,
sometimes with 1 enum value per line... and independently of that the
trailing comma is sometimes present and other times absent, often
mixing with/without trailing comma styles in a single file, and
sometimes in consecutive enum declarations.
Clearly, omitting the comma is the more portable style, and this patch
changes all enum declarations to use the portable omitted dangling
comma style consistently.
Signed-off-by: Gary V. Vaughan <gary@thewrittenword.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Without this patch at least IBM VisualAge C 5.0 (I have 5.0.2) on AIX
5.1 fails to compile git.
enum style is inconsistent already, with some enums declared on one
line, some over 3 lines with the enum values all on the middle line,
sometimes with 1 enum value per line... and independently of that the
trailing comma is sometimes present and other times absent, often
mixing with/without trailing comma styles in a single file, and
sometimes in consecutive enum declarations.
Clearly, omitting the comma is the more portable style, and this patch
changes all enum declarations to use the portable omitted dangling
comma style consistently.
Signed-off-by: Gary V. Vaughan <gary@thewrittenword.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
26 files changed:
attr.h | diff | blob | history | |
builtin/apply.c | diff | blob | history | |
builtin/branch.c | diff | blob | history | |
builtin/commit.c | diff | blob | history | |
builtin/help.c | diff | blob | history | |
builtin/mailinfo.c | diff | blob | history | |
builtin/receive-pack.c | diff | blob | history | |
builtin/remote.c | diff | blob | history | |
cache.h | diff | blob | history | |
commit.h | diff | blob | history | |
connect.c | diff | blob | history | |
ctype.c | diff | blob | history | |
diff.h | diff | blob | history | |
dir.c | diff | blob | history | |
fast-import.c | diff | blob | history | |
grep.h | diff | blob | history | |
http-push.c | diff | blob | history | |
http-walker.c | diff | blob | history | |
imap-send.c | diff | blob | history | |
merge-recursive.h | diff | blob | history | |
parse-options.h | diff | blob | history | |
pretty.c | diff | blob | history | |
remote.h | diff | blob | history | |
rerere.c | diff | blob | history | |
revision.c | diff | blob | history | |
wt-status.h | diff | blob | history |