Code

enums: omit trailing comma for portability
authorGary V. Vaughan <git@mlists.thewrittenword.com>
Fri, 14 May 2010 09:31:35 +0000 (09:31 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 31 May 2010 23:59:27 +0000 (16:59 -0700)
commit4b05548fc0523744b7a1276cfa0f4aae19d6d9c9
treebaf4bc01f49247b8811ed5d87dede2456e8b5eff
parent48793cf46a286a21df420fdd7fc4b0c91c60a0c8
enums: omit trailing comma for portability

Without this patch at least IBM VisualAge C 5.0 (I have 5.0.2) on AIX
5.1 fails to compile git.

enum style is inconsistent already, with some enums declared on one
line, some over 3 lines with the enum values all on the middle line,
sometimes with 1 enum value per line... and independently of that the
trailing comma is sometimes present and other times absent, often
mixing with/without trailing comma styles in a single file, and
sometimes in consecutive enum declarations.

Clearly, omitting the comma is the more portable style, and this patch
changes all enum declarations to use the portable omitted dangling
comma style consistently.

Signed-off-by: Gary V. Vaughan <gary@thewrittenword.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
26 files changed:
attr.h
builtin/apply.c
builtin/branch.c
builtin/commit.c
builtin/help.c
builtin/mailinfo.c
builtin/receive-pack.c
builtin/remote.c
cache.h
commit.h
connect.c
ctype.c
diff.h
dir.c
fast-import.c
grep.h
http-push.c
http-walker.c
imap-send.c
merge-recursive.h
parse-options.h
pretty.c
remote.h
rerere.c
revision.c
wt-status.h