Code

completion: don't leak variable from the prompt into environment
authorSZEDER Gábor <szeder@ira.uka.de>
Wed, 9 Nov 2011 10:02:50 +0000 (11:02 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 9 Nov 2011 13:44:05 +0000 (05:44 -0800)
commit4804d437916d08068143dfc265cc7b5e2f4883e6
tree6fbe88da4d83f1641c0625034a8c604632290f9c
parente5b8eebc03f80bc21877494ae2ac0c2b63a1b83b
completion: don't leak variable from the prompt into environment

Commit e5b8eebc (completion: fix issue with process substitution not
working on Git for Windows, 2011-10-26) introduced a new variable in
__git_ps1_show_upstream(), but didn't declare it as local to prevent it
from leaking into the environment.

We may want to rewrite it like the following, but that can wait until the
next cycle.

while read key value
do
...
done <<-EOF
$(git config -z --get-regexp ...)
EOF

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/completion/git-completion.bash