author | Linus Torvalds <torvalds@linux-foundation.org> | |
Wed, 21 Mar 2007 17:09:56 +0000 (10:09 -0700) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Wed, 21 Mar 2007 18:15:26 +0000 (11:15 -0700) | ||
commit | 4651ece8540a90a42af355e995847fb89192cc81 | |
tree | 274ddb9d65ca6c0df89585a3a62d1befb1ddd7cb | tree | snapshot |
parent | 6fda5e5180c2e7c130978361aea53b4e66f36823 | commit | diff |
Switch over tree descriptors to contain a pre-parsed entry
This makes the tree descriptor contain a "struct name_entry" as part of
it, and it gets filled in so that it always contains a valid entry. On
some benchmarks, it improves performance by up to 15%.
That makes tree entry "extract" trivial, and means that we only actually
need to decode each tree entry just once: we decode the first one when
we initialize the tree descriptor, and each subsequent one when doing
"update_tree_entry()". In particular, this means that we don't need to
do strlen() both at extract time _and_ at update time.
Finally, it also allows more sharing of code (entry_extract(), that
wanted a "struct name_entry", just got totally trivial, along with the
"tree_entry()" function).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This makes the tree descriptor contain a "struct name_entry" as part of
it, and it gets filled in so that it always contains a valid entry. On
some benchmarks, it improves performance by up to 15%.
That makes tree entry "extract" trivial, and means that we only actually
need to decode each tree entry just once: we decode the first one when
we initialize the tree descriptor, and each subsequent one when doing
"update_tree_entry()". In particular, this means that we don't need to
do strlen() both at extract time _and_ at update time.
Finally, it also allows more sharing of code (entry_extract(), that
wanted a "struct name_entry", just got totally trivial, along with the
"tree_entry()" function).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
tree-walk.c | diff | blob | history | |
tree-walk.h | diff | blob | history |