author | Jeff King <peff@peff.net> | |
Wed, 30 Dec 2009 11:01:09 +0000 (06:01 -0500) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 6 Jan 2010 07:41:51 +0000 (23:41 -0800) | ||
commit | 41a457e4f814a0e514548b3178e7692129f0fcfe | |
tree | 3b1a66dac76d179328110fe33c92f728ce7410e2 | tree | snapshot |
parent | bac8037081735a49bccdc3b3b1457129f9bcc451 | commit | diff |
textconv: use shell to run helper
Currently textconv helpers are run directly. Running through
the shell is useful because the user can provide a program
with command line arguments, like "antiword -f".
It also makes textconv more consistent with other parts of
git, most of which run their helpers using the shell.
The downside is that textconv helpers with shell
metacharacters (like space) in the filename will be broken.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Currently textconv helpers are run directly. Running through
the shell is useful because the user can provide a program
with command line arguments, like "antiword -f".
It also makes textconv more consistent with other parts of
git, most of which run their helpers using the shell.
The downside is that textconv helpers with shell
metacharacters (like space) in the filename will be broken.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff.c | diff | blob | history | |
t/t4030-diff-textconv.sh | diff | blob | history | |
t/t4031-diff-rewrite-binary.sh | diff | blob | history |