author | Benjamin Kramer <benny.kra@googlemail.com> | |
Mon, 27 Apr 2009 13:59:49 +0000 (15:59 +0200) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 29 Apr 2009 23:50:21 +0000 (16:50 -0700) | ||
commit | 3e8a00ae1d529e61f38f36fdb504902064cf1f5d | |
tree | f630ee010c86c033a73ffa4420ea77399a973947 | tree | snapshot |
parent | 0c44c94309693d0582e91a6744edc2e8eba46ef8 | commit | diff |
daemon.c: fix segfault on OS X
On OS X (and maybe other unices), getaddrinfo(3) returns NULL
in the ai_canonname field if it's called with an IP address for
the hostname. We'll now use the IP address for the hostname if
ai_canonname was NULL, this also matches the behaviour on Linux.
steps to reproduce:
$ git daemon --export-all
$ git clone git://127.0.0.1/frotz
=> git daemon's fork (silently) segfaults.
Remove the pointless loop while at it. There is only one iteration
because of the break; on the last line and there are no continues.
Signed-off-by: Benjamin Kramer <benny.kra@googlemail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
On OS X (and maybe other unices), getaddrinfo(3) returns NULL
in the ai_canonname field if it's called with an IP address for
the hostname. We'll now use the IP address for the hostname if
ai_canonname was NULL, this also matches the behaviour on Linux.
steps to reproduce:
$ git daemon --export-all
$ git clone git://127.0.0.1/frotz
=> git daemon's fork (silently) segfaults.
Remove the pointless loop while at it. There is only one iteration
because of the break; on the last line and there are no continues.
Signed-off-by: Benjamin Kramer <benny.kra@googlemail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
daemon.c | diff | blob | history |