author | Junio C Hamano <gitster@pobox.com> | |
Fri, 3 Jun 2011 22:32:17 +0000 (15:32 -0700) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 6 Jun 2011 05:45:38 +0000 (22:45 -0700) | ||
commit | 3de89c9d4216d0fdc11bd1141c419ac4d0d35fed | |
tree | 218f4d8958273c4685df94b1772ad9de4ed30b22 | tree | snapshot |
parent | d1a0ed187cbea2941a5cc10dcc43f3a7052ce32d | commit | diff |
verify-pack: use index-pack --verify
This finally gets rid of the inefficient verify-pack implementation that
walks objects in the packfile in their object name order and replaces it
with a call to index-pack --verify. As a side effect, it also removes
packed_object_info_detail() API which is rather expensive.
As this changes the way errors are reported (verify-pack used to rely on
the usual runtime error detection routine unpack_entry() to diagnose the
CRC errors in an entry in the *.idx file; index-pack --verify checks the
whole *.idx file in one go), update a test that expected the string "CRC"
to appear in the error message.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This finally gets rid of the inefficient verify-pack implementation that
walks objects in the packfile in their object name order and replaces it
with a call to index-pack --verify. As a side effect, it also removes
packed_object_info_detail() API which is rather expensive.
As this changes the way errors are reported (verify-pack used to rely on
the usual runtime error detection routine unpack_entry() to diagnose the
CRC errors in an entry in the *.idx file; index-pack --verify checks the
whole *.idx file in one go), update a test that expected the string "CRC"
to appear in the error message.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/verify-pack.c | diff | blob | history | |
cache.h | diff | blob | history | |
sha1_file.c | diff | blob | history | |
t/t5302-pack-index.sh | diff | blob | history |