![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | Sverre Hvammen Johansen <hvammen+git@gmail.com> | |
| Sun, 13 Jul 2008 08:13:55 +0000 (08:13 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 13 Jul 2008 20:53:54 +0000 (13:53 -0700) | ||
| commit | 3d1dd4728b83e4c08d9fa7aaf2aa946e1012e061 | |
| tree | c16f233808218d861b069d481fc95265e2716c01 | tree | snapshot |
| parent | 3f4d1c639347317788f2c5080f89de53772499ce | commit | diff |
reduce_heads(): thinkofix
When comparing two commit objects for equality, it is sufficient to
compare their in-core pointers because the object layer guarantees the
uniqueness. However, comparing pointers to two "struct commit_list"
instances that point at the same commit does not make any sense.
Spotted by Sverre Hvammen Johansen who wrote an additional test to expose
the problem, fixed by Miklos Vajna.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When comparing two commit objects for equality, it is sufficient to
compare their in-core pointers because the object layer guarantees the
uniqueness. However, comparing pointers to two "struct commit_list"
instances that point at the same commit does not make any sense.
Spotted by Sverre Hvammen Johansen who wrote an additional test to expose
the problem, fixed by Miklos Vajna.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| commit.c | diff | blob | history | |
| t/t7600-merge.sh | diff | blob | history |