author | Jeff King <peff@peff.net> | |
Fri, 14 Dec 2007 09:15:47 +0000 (04:15 -0500) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 14 Dec 2007 20:06:04 +0000 (12:06 -0800) | ||
commit | 38a5b1d6ed2ba632504be7748e63f1441c93976d | |
tree | 557ba97485246ff7fd626221928c81a06b9b549f | tree | snapshot |
parent | 71362bd55280bb0f4aa67f89435308a4b26213b5 | commit | diff |
cvsexportcommit: fix massive commits
Because we feed the changed filenames to CVS on the command
line, it was possible for massive commits to overflow the
system exec limits. Instead, we now do an xargs-like split
of the arguments.
This means that we lose some of the atomicity of calling CVS
in one shot. Since CVS commits are not atomic, but the CVS
protocol is, the possible effects of this are not clear;
however, since CVS doesn't provide a different interface,
this is our only option for large commits (short of writing
a CVS client library).
The argument size limit is arbitrarily set to 64kB. This
should be high enough to trigger only in rare cases where it
is necessary, so normal-sized commits are not affected by
the atomicity change.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Because we feed the changed filenames to CVS on the command
line, it was possible for massive commits to overflow the
system exec limits. Instead, we now do an xargs-like split
of the arguments.
This means that we lose some of the atomicity of calling CVS
in one shot. Since CVS commits are not atomic, but the CVS
protocol is, the possible effects of this are not clear;
however, since CVS doesn't provide a different interface,
this is our only option for large commits (short of writing
a CVS client library).
The argument size limit is arbitrarily set to 64kB. This
should be high enough to trigger only in rare cases where it
is necessary, so normal-sized commits are not affected by
the atomicity change.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-cvsexportcommit.perl | diff | blob | history |