author | Jeff King <peff@peff.net> | |
Fri, 17 Jun 2011 20:36:32 +0000 (16:36 -0400) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 17 Jun 2011 20:48:53 +0000 (13:48 -0700) | ||
commit | 36bfb0e5f6004e4c4ac9334107dc185c316839a7 | |
tree | 0d572261e1ef9c209be19a853be46124fd664f3a | tree | snapshot |
parent | 7ef4d6b928281eff2bfcd0b3d76b80f4385f2f3d | commit | diff |
tests: link shell libraries into valgrind directory
When we run tests under valgrind, we symlink anything
executable that starts with git-* or test-* into a special
valgrind bin directory, and then make that our
GIT_EXEC_PATH.
However, shell libraries like git-sh-setup do not have the
executable bit marked, and did not get symlinked. This
means that any test looking for shell libraries in our
exec-path would fail to find them, even though that is a
fine thing to do when testing against a regular git build
(or in a git install, for that matter).
t2300 demonstrated this problem. The fix is to symlink these
shell libraries directly into the valgrind directory.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When we run tests under valgrind, we symlink anything
executable that starts with git-* or test-* into a special
valgrind bin directory, and then make that our
GIT_EXEC_PATH.
However, shell libraries like git-sh-setup do not have the
executable bit marked, and did not get symlinked. This
means that any test looking for shell libraries in our
exec-path would fail to find them, even though that is a
fine thing to do when testing against a regular git build
(or in a git install, for that matter).
t2300 demonstrated this problem. The fix is to symlink these
shell libraries directly into the valgrind directory.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/test-lib.sh | diff | blob | history |