author | Johannes Sixt <j6t@kdbg.org> | |
Tue, 10 Mar 2009 21:54:17 +0000 (22:54 +0100) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 11 Mar 2009 06:23:02 +0000 (23:23 -0700) | ||
commit | 34df8abaf358c83cc1447d0a81bda7848685a1c9 | |
tree | a886a53059e8fbad18429de73c620c4af306d301 | tree | snapshot |
parent | c4994ce953b4f0fdbf80004da24ef845907d7dd8 | commit | diff |
recv_sideband: Bands #2 and #3 always go to stderr
This removes the last parameter of recv_sideband, by which the callers
told which channel bands #2 and #3 should be written to.
Sayeth Shawn Pearce:
The definition of the streams in the current sideband protocol
are rather well defined for the one protocol that uses it,
fetch-pack/receive-pack:
stream #1: pack data
stream #2: stderr messages, progress, meant for tty
stream #3: abort message, remote is dead, goodbye!
Since both callers of the function passed 2 for the parameter, we hereby
remove it and send bands #2 and #3 to stderr explicitly using fprintf.
This has the nice side-effect that these two streams pass through our
ANSI emulation layer on Windows.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This removes the last parameter of recv_sideband, by which the callers
told which channel bands #2 and #3 should be written to.
Sayeth Shawn Pearce:
The definition of the streams in the current sideband protocol
are rather well defined for the one protocol that uses it,
fetch-pack/receive-pack:
stream #1: pack data
stream #2: stderr messages, progress, meant for tty
stream #3: abort message, remote is dead, goodbye!
Since both callers of the function passed 2 for the parameter, we hereby
remove it and send bands #2 and #3 to stderr explicitly using fprintf.
This has the nice side-effect that these two streams pass through our
ANSI emulation layer on Windows.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-archive.c | diff | blob | history | |
builtin-fetch-pack.c | diff | blob | history | |
sideband.c | diff | blob | history | |
sideband.h | diff | blob | history |