author | James Bottomley <James.Bottomley@SteelEye.com> | |
Sat, 13 Aug 2005 15:29:32 +0000 (10:29 -0500) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Sun, 14 Aug 2005 01:28:52 +0000 (18:28 -0700) | ||
commit | 31f584c242e7af28018ff920b6c8d1952beadbd4 | |
tree | 4b209a3762c91b811640bdf3f0b1ca2e3de2ad15 | tree | snapshot |
parent | 3c3852e33b3e40ad64885d845cb92a52c7b15884 | commit | diff |
[PATCH] fix git-checkout-cache segfault on parisc
The index cleanup code is executed via atexit() which is *after* main
has completed, so the stack allocated cache_file has gone out of scope.
Parisc seems to use stack in the destructor functions, so cache_file
gets partially overwritten leading to the predictable disastrous
consequences.
[jc: Just to make sure, I audited other users of the function
hold_index_file_for_update() to make sure they do not have this
problem; everybody else uses non-stack cache_file structure and
is fine. Thanks, James.]
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
The index cleanup code is executed via atexit() which is *after* main
has completed, so the stack allocated cache_file has gone out of scope.
Parisc seems to use stack in the destructor functions, so cache_file
gets partially overwritten leading to the predictable disastrous
consequences.
[jc: Just to make sure, I audited other users of the function
hold_index_file_for_update() to make sure they do not have this
problem; everybody else uses non-stack cache_file structure and
is fine. Thanks, James.]
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
checkout-cache.c | diff | blob | history |