![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
| author | oetiker <oetiker@a5681a0c-68f1-0310-ab6d-d61299d08faa> | |
| Sun, 22 Aug 2010 17:56:02 +0000 (17:56 +0000) | ||
| committer | oetiker <oetiker@a5681a0c-68f1-0310-ab6d-d61299d08faa> | |
| Sun, 22 Aug 2010 17:56:02 +0000 (17:56 +0000) | ||
| commit | 31b069e6cb93b94353c97149642a6d2787528f2d | |
| tree | 1d8ad40cafc66773024197a9c10550a189351444 | tree | snapshot |
| parent | 84d6985d89788a3208f0b513155f67cf1f77759d | commit | diff |
First bug: in function rrd_fetch_fn_libdbi() variable 'struct sql_table_helper table_help'
field 'filename' is uninitialized. So, if a sql error happens, it does not print an error like this
rrd_set_error( "libdbi: problems connecting to db with connect string %s - error: %s",th->filename,dbi_errstr);
instead of, it dumps core.
Second bug: when the output data buffer is allocated, it allocated for 'rows-1' max index, but in
'fetch loop' 'idx' may be equal to 'rows', so it needs one more extra record in data.
-- Pavel Nikiforov pavel artx.ru
git-svn-id: svn://svn.oetiker.ch/rrdtool/branches/1.4/program@2118 a5681a0c-68f1-0310-ab6d-d61299d08faa
field 'filename' is uninitialized. So, if a sql error happens, it does not print an error like this
rrd_set_error( "libdbi: problems connecting to db with connect string %s - error: %s",th->filename,dbi_errstr);
instead of, it dumps core.
Second bug: when the output data buffer is allocated, it allocated for 'rows-1' max index, but in
'fetch loop' 'idx' may be equal to 'rows', so it needs one more extra record in data.
-- Pavel Nikiforov pavel artx.ru
git-svn-id: svn://svn.oetiker.ch/rrdtool/branches/1.4/program@2118 a5681a0c-68f1-0310-ab6d-d61299d08faa
| src/rrd_fetch_libdbi.c | diff | blob | history |