author | Jeff King <peff@peff.net> | |
Wed, 25 Jun 2008 05:41:34 +0000 (01:41 -0400) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 25 Jun 2008 18:44:15 +0000 (11:44 -0700) | ||
commit | 2beebd22f4af8788eaf19d811de03191ae6f7c42 | |
tree | 2bd7780907fee1af1ef5e6607b8e3dc090cbb62d | tree | snapshot |
parent | 4ace4fc584f48d5b8df957c4462cf5c7c58ab100 | commit | diff |
clone: create intermediate directories of destination repo
The shell version used to use "mkdir -p" to create the repo
path, but the C version just calls "mkdir". Let's replicate
the old behavior. We have to create the git and worktree
leading dirs separately; while most of the time, the
worktree dir contains the git dir (as .git), the user can
override this using GIT_WORK_TREE.
We can reuse safe_create_leading_directories, but we need to
make a copy of our const buffer to do so. Since
merge-recursive uses the same pattern, we can factor this
out into a global function. This has two other cleanup
advantages for merge-recursive:
1. mkdir_p wasn't a very good name. "mkdir -p foo/bar" actually
creates bar, but this function just creates the leading
directories.
2. mkdir_p took a mode argument, but it was completely
ignored.
Acked-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The shell version used to use "mkdir -p" to create the repo
path, but the C version just calls "mkdir". Let's replicate
the old behavior. We have to create the git and worktree
leading dirs separately; while most of the time, the
worktree dir contains the git dir (as .git), the user can
override this using GIT_WORK_TREE.
We can reuse safe_create_leading_directories, but we need to
make a copy of our const buffer to do so. Since
merge-recursive uses the same pattern, we can factor this
out into a global function. This has two other cleanup
advantages for merge-recursive:
1. mkdir_p wasn't a very good name. "mkdir -p foo/bar" actually
creates bar, but this function just creates the leading
directories.
2. mkdir_p took a mode argument, but it was completely
ignored.
Acked-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-clone.c | diff | blob | history | |
builtin-merge-recursive.c | diff | blob | history | |
cache.h | diff | blob | history | |
sha1_file.c | diff | blob | history | |
t/t5601-clone.sh | diff | blob | history |