author | Linus Torvalds <torvalds@linux-foundation.org> | |
Thu, 18 Jun 2009 17:28:43 +0000 (10:28 -0700) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Sun, 21 Jun 2009 04:52:55 +0000 (21:52 -0700) | ||
commit | 2af202be3d2f128c6974290cabe13179c6462196 | |
tree | c0cdbb5c0b4fc3ea464ede43100063c8fd455fe4 | tree | snapshot |
parent | a49eb197d809d2d7efbd81d935c61e1a0caa983e | commit | diff |
Fix various sparse warnings in the git source code
There are a few remaining ones, but this fixes the trivial ones. It boils
down to two main issues that sparse complains about:
- warning: Using plain integer as NULL pointer
Sparse doesn't like you using '0' instead of 'NULL'. For various good
reasons, not the least of which is just the visual confusion. A NULL
pointer is not an integer, and that whole "0 works as NULL" is a
historical accident and not very pretty.
A few of these remain: zlib is a total mess, and Z_NULL is just a 0.
I didn't touch those.
- warning: symbol 'xyz' was not declared. Should it be static?
Sparse wants to see declarations for any functions you export. A lack
of a declaration tends to mean that you should either add one, or you
should mark the function 'static' to show that it's in file scope.
A few of these remain: I only did the ones that should obviously just
be made static.
That 'wt_status_submodule_summary' one is debatable. It has a few related
flags (like 'wt_status_use_color') which _are_ declared, and are used by
builtin-commit.c. So maybe we'd like to export it at some point, but it's
not declared now, and not used outside of that file, so 'static' it is in
this patch.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
There are a few remaining ones, but this fixes the trivial ones. It boils
down to two main issues that sparse complains about:
- warning: Using plain integer as NULL pointer
Sparse doesn't like you using '0' instead of 'NULL'. For various good
reasons, not the least of which is just the visual confusion. A NULL
pointer is not an integer, and that whole "0 works as NULL" is a
historical accident and not very pretty.
A few of these remain: zlib is a total mess, and Z_NULL is just a 0.
I didn't touch those.
- warning: symbol 'xyz' was not declared. Should it be static?
Sparse wants to see declarations for any functions you export. A lack
of a declaration tends to mean that you should either add one, or you
should mark the function 'static' to show that it's in file scope.
A few of these remain: I only did the ones that should obviously just
be made static.
That 'wt_status_submodule_summary' one is debatable. It has a few related
flags (like 'wt_status_use_color') which _are_ declared, and are used by
builtin-commit.c. So maybe we'd like to export it at some point, but it's
not declared now, and not used outside of that file, so 'static' it is in
this patch.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
23 files changed:
bisect.c | diff | blob | history | |
builtin-add.c | diff | blob | history | |
builtin-apply.c | diff | blob | history | |
builtin-clone.c | diff | blob | history | |
builtin-fsck.c | diff | blob | history | |
builtin-help.c | diff | blob | history | |
builtin-log.c | diff | blob | history | |
builtin-merge.c | diff | blob | history | |
builtin-remote.c | diff | blob | history | |
builtin-unpack-objects.c | diff | blob | history | |
connect.c | diff | blob | history | |
daemon.c | diff | blob | history | |
http-push.c | diff | blob | history | |
imap-send.c | diff | blob | history | |
index-pack.c | diff | blob | history | |
mailmap.c | diff | blob | history | |
merge-recursive.c | diff | blob | history | |
parse-options.c | diff | blob | history | |
quote.c | diff | blob | history | |
remote.c | diff | blob | history | |
test-parse-options.c | diff | blob | history | |
unpack-trees.c | diff | blob | history | |
wt-status.c | diff | blob | history |