author | Junio C Hamano <junkio@cox.net> | |
Wed, 28 Jun 2006 08:38:19 +0000 (01:38 -0700) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Wed, 28 Jun 2006 08:38:19 +0000 (01:38 -0700) | ||
commit | 2386c2975d66e03d02a9ebf15a1d07092975e527 | |
tree | dc5a063cb2bbfe3ff18e1b5feaed17e75b2de5aa | tree | snapshot |
parent | 8dcaefb52f81115d71e1dfa27d45f4a677bcbc09 | commit | diff |
combine-diff.c: type sanity
- combine_diff() took cnt (count) which is unsigned in nature but the
parameter type was declared as "int";
- find_next() took "uninteresting" parameter, which masked a static
function of the same name;
- show_parent_lno() took an unused parameter "cnt";
- show_patch_diff() used a local variable in nested inner scope with
the same name with different type, masking the one in the outer scope;
- the last loop in show_patch_diff iterated over lines so it should use
the local variable "lno"
Signed-off-by: Junio C Hamano <junkio@cox.net>
- combine_diff() took cnt (count) which is unsigned in nature but the
parameter type was declared as "int";
- find_next() took "uninteresting" parameter, which masked a static
function of the same name;
- show_parent_lno() took an unused parameter "cnt";
- show_patch_diff() used a local variable in nested inner scope with
the same name with different type, masking the one in the outer scope;
- the last loop in show_patch_diff iterated over lines so it should use
the local variable "lno"
Signed-off-by: Junio C Hamano <junkio@cox.net>
combine-diff.c | diff | blob | history |